-
Notifications
You must be signed in to change notification settings - Fork 239
Avoid warnings when compiling under Wpedantic
#437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5a6dea3
6d628d6
acc7758
4b5e033
a28c53c
5f6ec19
43b4edf
da0746b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2064,7 +2064,7 @@ typedef struct REExecState { | |
| size_t count; /* only used for RE_EXEC_STATE_GREEDY_QUANT */ | ||
| const uint8_t *cptr; | ||
| const uint8_t *pc; | ||
| void *buf[0]; | ||
| void *buf[]; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We did not use the standard flexible array syntax because it was not supported by older compilers on some targets, possibly in the embedded world. We do use compound literals so it is unlikely for the compiler to support this and not that. All targets in the CI seem happy so I would OK this change. |
||
| } REExecState; | ||
|
|
||
| typedef struct { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was definitely an oversight. Should have used
uint128_tfrom day one.