Small fixes in Date.parse #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chqrlie
commented
Mar 27, 2024
chqrlie
commented
- reject AM/PM suffix for hours > 12
- stricter time parser (fixes last v8 test)
- reject AM/PM suffix for hours > 12 - stricter time parser (fixes last v8 test)
saghul
approved these changes
Mar 27, 2024
bnoordhuis
reviewed
Mar 27, 2024
| } else | ||
| if (has_time && string_match(sp, &p, "PM")) { | ||
| if (fields[3] < 12) | ||
| if (fields[3] != 12) |
Contributor
There was a problem hiding this comment.
Should this also have a range check?
Suggested change
| if (fields[3] != 12) | |
| if (fields[3] > 12) | |
| return FALSE; | |
| if (fields[3] != 12) |
It looks like it'd accept e.g. 13:00 PM now.
Collaborator
Author
There was a problem hiding this comment.
The test fields[3] != 12 suffices to reject hours larger than 12 because they will be incremented and exceed 24, thus be caught by the range check in js_Date_parse().
Collaborator
Author
There was a problem hiding this comment.
I shall add an explanatory comment for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.