Run V8 spec conformance test suite #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Jan 1, 2024
Contributor
saghul
left a comment
saghul
left a comment
There was a problem hiding this comment.
LGTM, nice! How do you plan to ignore failures on the newly added test step?
Contributor
Author
By updating v8.txt. The shell script prints the diff that needs to be applied. I took a slightly different tack in this revision. Instead of a separate context I now run tests in a separate process. Some of the tests need TZ set to a specific value. |
Contributor
Author
Forgot to mention, you can also copy the temp file over v8.txt locally. Amounts to the same thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell script runs the JS runner and diffs its stderr with v8.txt. Lines added/removed means tests were fixed/broken.
I added functions to qjs to let the JS runner execute tests in a separate context.
Future work is to a) fix failing tests, and b) enable more tests. A number are disabled for various reasons and mjsunit subdirectories are currently skipped. Need to decide on a case-by-case basis what is and isn't relevant to us.
At the moment about 430 tests are run of which approx. 345 or 80% pass.