Group field whose elements do not have the same fields are incorrectly parsed #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partly revert change in quickfixgo#368 due to breaking the unit test added in this PR
|
#622 is the same issue as this |
|
Thanks @albertsundjaja, confirming that this would solve my issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edge case is described in the unit test added in this PR
When a group field contains more than one element and one of the elements has less params (because they are optional), it will be parsed incorrectly due to the change added in #368
e.g.
in the example, the last element does not have 523 defined
this means that a fix for #365 / #366 is still required