Skip to content

Tls server name config#385

Merged
cbusbey merged 4 commits intoquickfixgo:masterfrom
linmaosong2018:tls-server-name-config
Nov 9, 2019
Merged

Tls server name config#385
cbusbey merged 4 commits intoquickfixgo:masterfrom
linmaosong2018:tls-server-name-config

Conversation

@linmaosong2018
Copy link
Contributor

Fixes #384:

  • Support TLS SNI by passing in ServerName configuration
  • If
    -- InsecureSkipVerify is false
    -- ServerName not configured
    then copy the host part of the connection address as the ServerName. This essentially restores the behavior before ce2275b

Tests done:

@cbusbey
Copy link
Contributor

cbusbey commented Nov 9, 2019

👍

@cbusbey cbusbey merged commit 76e0003 into quickfixgo:master Nov 9, 2019
@linmaosong2018 linmaosong2018 deleted the tls-server-name-config branch November 11, 2019 08:19
level2player pushed a commit to longbridge/quickfix that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replacing tls.DialWithDialer with tls.Client breaks Client Hello

2 participants