Adapt sql for postgres#283
Closed
anphung wants to merge 1 commit intoquickfixgo:masterfrom
anphung:fix/postgres
Closed
Adapt sql for postgres#283anphung wants to merge 1 commit intoquickfixgo:masterfrom anphung:fix/postgres
anphung wants to merge 1 commit intoquickfixgo:masterfrom
anphung:fix/postgres
Conversation
Contributor
|
Hi @anphung, First of all, apologies for the late response. I try to respond to requests asap, this one got away from me. It is unfortunate that the sql driver placeholders are not abstracted... In the best interests of longer term planning to support a range of db impls, instead of a conditional block based on the underlying driver, we would rather either use a dep to handle this abstraction, or handle it internally with our own polymorphism (probably the latter). I'll create an issue so that we can track this to be fixed in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
?vs$1