Skip to content

MSSQL script: Wrong data type for creation_time #664

Description

@TatuMon

My problem

Today I found out that, while the creation_time is saved following the specified timezone set in the configuration, it's not saving the timezone in the database, what makes StateMachine.CheckSessionTime behave weird.

How I found out

Config

  • BeginString=FIXT.1.1
  • StartTime=09:40:00
  • EndTime=19:00:00
  • Weekdays=Mon,Tue,Wed,Thu,Fri
  • TimeZone=Local (which is UTC-3 in the machine where I found this)
  • ... more

Initially, my session was created with creation_time set at "2024-08-20 12:35:37.787", which is fine, but the session kept resetting and I found out that if I set StartTime=09:35:37 (or before) it works.

I assume this is because creation_time doesn't specify timezone, what makes the code assume it is in UTC and reduce 3 hours from it, thus making creation_time out of range

Activity

  1. ackleymi commented on Aug 22, 2024

    @ackleymi
    Member

    I think I understand the problem, and I think the only repo that might have a solution for us to follow here would be quickfix-j. I think changing the datatype for this db field is the wrong way to go, those db scripts are standard across all quickfix implementations, therefore the solution must be in code. If you could push a unit test that fails and demonstrates the problem that would help.

  2. TatuMon commented on Aug 27, 2024

    @TatuMon
    Author

    Sorry for the late response.

    Currently I don't have the time to do so, I'm sorry, and I, honestly, don't know how to rn. I'm quite new to Golang and I've been learning the FIX protocol for a few days only.

    I wanted to let you know about this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions