Skip to content

No-op stores does nothing hence test class is not needed. #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions quickfixj-core/src/main/java/quickfix/NoopStore.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@

package quickfix;

import org.slf4j.LoggerFactory;

import java.util.Collection;
import java.util.Date;

Expand All @@ -32,16 +30,10 @@
*/
public class NoopStore implements MessageStore {

private final SessionID sessionID;

private Date creationTime = new Date();
private int nextSenderMsgSeqNum = 1;
private int nextTargetMsgSeqNum = 1;

public NoopStore(SessionID sessionID) {
this.sessionID = sessionID;
}

public void get(int startSequence, int endSequence, Collection<String> messages) {
}

Expand Down Expand Up @@ -84,12 +76,5 @@ public void setNextTargetMsgSeqNum(int next) {
}

public void refresh() {
final String text = "No-op store does not support refresh!";
if (sessionID != null) {
final Session session = Session.lookupSession(sessionID);
session.getLog().onErrorEvent("ERROR: " + text);
} else {
LoggerFactory.getLogger(NoopStore.class).error(text);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ public final class NoopStoreFactory implements MessageStoreFactory {

@Override
public MessageStore create(SessionID sessionID) {
return new NoopStore(sessionID);
return new NoopStore();
}
}
31 changes: 0 additions & 31 deletions quickfixj-core/src/test/java/quickfix/NoopStoreTest.java

This file was deleted.