Skip to content

QFJ-656 - fixed logic around field validation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 5, 2016
Merged

QFJ-656 - fixed logic around field validation #57

merged 5 commits into from
Jan 5, 2016

Conversation

@the-thing
Copy link
Contributor

@the-thing the-thing commented Jan 4, 2016

Change notes:

  • validation logic is fixed for messages and groups
  • unit tests added in quickfix.DataDictionaryTest
  • quickfix.DataDictionaryTest was refactored to JUnit 4 style to utilise ExpectedException rule
  • configuration.html documentation changed for AllowUnknownMsgFields and ValidateUserDefinedFields not to be confusing and in similar style

@the-thing
Copy link
Contributor Author

the-thing commented Jan 5, 2016

Hi Christoph,

You are right. For some reason TortoiseGit didn't show me configuration.html blank character changes. I see them in Eclipse. Let me fix that.

@the-thing
Copy link
Contributor Author

the-thing commented Jan 5, 2016

Looking better.

@chrjohn
Copy link
Member

chrjohn commented Jan 5, 2016

Thank you, I will take a look at it.

chrjohn added a commit that referenced this pull request Jan 5, 2016
@chrjohn
Merge pull request #57 from the-thing/allowUnknownMsgFieldsFix
fbafe6b 
QFJ-656 - fixed logic around field validation
@chrjohn chrjohn merged commit fbafe6b into quickfix-j:master Jan 5, 2016
@chrjohn
Copy link
Member

chrjohn commented Jan 5, 2016

Just merged, will also merge to 1.6 branch later. Thanks for the good documentation of the unit tests. :)

chrjohn added a commit that referenced this pull request Jan 6, 2016
@chrjohn
Merge pull request #57 from the-thing/allowUnknownMsgFieldsFix
13b081b 
QFJ-656 - fixed logic around field validation
(cherry picked from commit fbafe6b)
@chrjohn chrjohn added this to the QFJ 1.6.2 milestone Mar 24, 2016
david-gibbs-ig pushed a commit to IG-Group/quickfixj that referenced this pull request Apr 21, 2020
@matthew-peacock-ig
Merge pull request quickfix-j#57 in FO/quickfixj from FIXAPI-1370-QFJ…
fd0f5c1 
…-With-GuaranteedStop to QFJ_RELEASE_2_1_0_IG_OTC

* commit 'b391ce36e174b79cf4e32dbbd51f96c7e153ea63':
  FIXAPI-1370 - Added Order Attribute Group to New Order List
  FIXAPI-1370 - Fixed Typo
  FIXAPI-1370 - Implemented review comments
  FIXAPI-1370 - Guaranteed Stop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

QFJ 1.6.2

Development

Successfully merging this pull request may close these issues.

2 participants

@the-thing @chrjohn