Minor logging change and correction of and-clause in unit test #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrjohn
added a commit
that referenced
this pull request
Feb 9, 2018
(cherry picked from commit 2ec570e)
alphafoobar
reviewed
Feb 12, 2018
| @@ -198,7 +198,7 @@ public void testLogonWithoutHeartBtInt() throws Exception { | |||
| try { | |||
| handler.processMessage(mockIoSession, message); | |||
| } catch (Exception e) { | |||
| fail("No exception should be thrown!"); | |||
| fail("No exception should be thrown! " + e); | |||
There was a problem hiding this comment.
Hi @chrjohn - A little late and a minor point, but there isn't any need to catch an Exception here. If the exception is thrown the unit test will fail and by not catching the exception you will benefit from seeing the full stacktrace.
Cheers!
There was a problem hiding this comment.
Hi @alphafoobar , you are of course right.
That happens when you don't think about what you're doing. ;)
Thanks,
Chris.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.