QFJ-940 - Event log omits parts of received message in case of validation errors #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chrjohn
commented
Feb 2, 2018
chrjohn
commented
- added method Message.toRawString() which returns the message string as it was passed to the Message class
- in case of errors: log raw message data instead of incompletely parsed message
- added unit test
- improved some log messages in Session class
…ion errors - added method Message.toRawString() which returns the message string as it was passed to the Message class - added unit test - improved some log messages in Session class
…ion errors - in case of errors: log raw message data instead of incompletely parsed message
|
Hi Philip,
I hope it is still awesome although your comment was deleted in the meantime. ;)
Do you think it is feasible to include this into 2.0.1? It solves a bug but I had to add a new
public method to the Message class.
Thanks,
Chris.
…On 03/02/18 16:38, Philip wrote:
This is awesome @chrjohn <https://github.com/chrjohn> - I had a plan to add an |Application|
callback when a message was unable to be properly parsed (i.e. |getException() != null|) but
toRawString probably removes the need for this - and even if so this is obviously usable by it!
|
|
It's a pretty minor method as it's just exposing an existing various variable via a getter. I think it's okay for a patch release. 👍 |
philipwhiuk
approved these changes
Feb 5, 2018
chrjohn
added a commit
that referenced
this pull request
Feb 5, 2018
…tion errors (#172) * QFJ-940: Event log omits parts of received message in case of validation errors - in case of errors: log raw message data instead of incompletely parsed message - added method Message.toRawString() which returns the message string as it was passed to the Message class - added unit test - improved some log messages in Session class (cherry picked from commit 8d9b7ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.