Don't increment sequence number on rejected logon #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrjohn
pushed a commit
that referenced
this pull request
Jan 26, 2018
* Don't increment sequence number on rejected logon * Changed to check expected seqnum on RejectLogon * Reverted unnecessary change in SessionTest (cherry picked from commit b77de84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrjohn This is the slightly blunt approach. You mentioned a better approach would be to increment only if the sequence number was right. I'm happy for you to update this PR.
I've written a test for it though - that should pass with/without your tweak I think.