-
Couldn't load subscription status.
- Fork 654
Improvements #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improvements #1057
Conversation
quickfixj-core/src/main/java/quickfix/mina/initiator/AbstractSocketInitiator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please roll back the import changes.
done. out of curiosity - is the intention that we only import the classes that are required and not the whole package because importing is a compile time task and I don't think it has any latency implications. |
The intention is simply that one uses IntelliJ, another uses Eclipse, a third Netbeans and either has its own taste of how imports should be organized (unless you configure it the same for all IDEs). |
Got it. Thanks I've reverted the import changes. I didn't get much time after this initial one where my changes were around non-critical execution path which were called once maybe twice in the life cycle |
Changes :