Modular icons

[daPhipz]

This is WIP for #4, will work on it today after my regular job ;)

I didn't commit combine.sh yet, but here's what I came up with so far in sort of pseudocode:

#!/bin/bash

# Takes SVG files and layers them above each other.
# Make sure that the canvas size is the same in all files, otherwise the positioning of the images is not correct!

# TODO Check canvas sizes

INPUT_FILES=("$@")
OUTPUT=""

# Loop through INPUT_FILES and do 'svgo --pretty --indent 0 FILE'

# Make sure all files are in the correct format
for file in "${INPUT_FILES[@]}"; do
    svgo --pretty --indent 0 "$file"
done

# Take the first file and store it in TEMP_OUT.
cat "$OUTPUT" "${INPUT_FILES[0]}"

# Loop through all other files as FILE:
# Remove the </svg> tag from TEMP_OUT.
# Remove the <svg> tag from FILE.
# Cat the file to TEMP_OUT.

Fixes #4

[Lukewh]

I'd be happy to merge this PR as is to keep the moving of files separate to the combine script

[Lukewh]

Although this breaks the current minify script as the embedded Quickemu icons are removed from the distro icons

[daPhipz]

I'd be happy to merge this PR as is to keep the moving of files separate to the combine script

I don't quite understand - do you mean that you want to merge this PR as is and make combine.sh a separate PR?

[daPhipz]

Although this breaks the current minify script as the embedded Quickemu icons are removed from the distro icons

Yeah, I think it is more sensible to do this in one go

[daPhipz]

There we go!
Ready to merge from my side!

[daPhipz]

This ensures that the script will terminate if any of the commands executed by it fail.
May be useful for the other script as well...

[daPhipz]

...oops - totally forgot to actually call combine.sh in minify.sh 😂 (will rename the latter to build.sh, if you don't mind...)

[daPhipz]

Now it is ready!

I added some comments to build.sh, hopefully they help in understanding the changes. If you have questions - please do ask!

[Lukewh]

A few little bits.

Really great work though 👍 Looking forward to landing this - I've got updated fedora and ubuntu kylin logos ready but don't want to add them until this lands :)

[daPhipz]

Should we also put the "raw" material (i.e. distro icons and quickemu icon variants) in the release zip?

[Lukewh]

Should we also put the "raw" material (i.e. distro icons and quickemu icon variants) in the release zip?

I think adding the raw Quickemu logo is ok, I don't think we should distribute other logos explicitly (obviously they're in the repo, but only as SVGs) personally

[daPhipz]

Currently, this exports the quickemu icons as they are in the SVG (155x155px on a 512x512px canvas). So, there's still room for improvement ;)

[Lukewh]

👍 LGTM