Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellcheck GitHub Action #2

Merged
merged 5 commits into from
Oct 30, 2021
Merged

Conversation

daPhipz
Copy link
Member

@daPhipz daPhipz commented Oct 29, 2021

The main reason why I did this is, is because the path to the repo contains a space character on my machine. If you don't want the shellcheck action, do remove it 😉
It'd be nice if you could incorporate the fixes, though 👍

As part of that, I had to change the array syntax a bit (77ad2d1). Otherwise, the script would throw an error... I used this cheat sheet as a reference.

What do you think of this?

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@Lukewh Lukewh merged commit e380072 into quickemu-project:main Oct 30, 2021
@daPhipz daPhipz deleted the shellcheck branch October 31, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants