Skip to content

Conversation

@aaronkjones
Copy link

This pull request will add the QuIC Organization Repolinter Action. Please see https://github.com/quic/.github for more information.

@quic-nasserg
Copy link
Contributor

Hey Aaron, looks like the repolint file we have isn't compatible with the newer versions. I'll get it updated and passing, and then enable this action. Thanks!

@aaronkjones
Copy link
Author

👍 Thank you!

Change-Id: I2e28dc2002fea188a20b8947d3f8a508f5986caf
Signed-off-by: Nasser Grainawi <quic_nasserg@quicinc.com>
@quic-nasserg
Copy link
Contributor

@aaronkjones not sure why the repolinter action is failing. It works fine for me locally with:

docker run -t -v $PWD:/src -w /src ghcr.io/todogroup/repolinter:v0.11.1

Any ideas?

@mynameistechno
Copy link

@aaronkjones not sure why the repolinter action is failing. It works fine for me locally with:

docker run -t -v $PWD:/src -w /src ghcr.io/todogroup/repolinter:v0.11.1

Any ideas?

image

Maybe the repolinter in the GH Action version doesn't match v0.11.1 from the docker image.

@prototypicalpro should we be using the fork in todogroup now?

@mynameistechno
Copy link

mynameistechno commented Aug 3, 2021

@nasser-quicinc it looks like our default ruleset has this rule turned off license-detectable-by-licensee:

https://github.com/quic/.github/blob/main/repolint.json#L309

But it appears yours is set to error.

Given the other rules that already check for license files and headers, etc., we should just disable it for now here as well.

@prototypicalpro
Copy link

prototypicalpro commented Aug 3, 2021

@mynameistechno You should use the todogroup fork as it has the most up to date version of repolinter (the newrelic version is still using the newrelic repolinter fork, which isn't maintained). I haven't seen that bug before, however, so feel free to lmk if it's still in the todogroup fork and I can take a look.

@mynameistechno
Copy link

@mynameistechno You should use the todogroup fork as it has the most up to date version of repolinter (the newrelic version is still using the newrelic repolinter fork, which isn't maintained). I haven't seen that bug before, however, so feel free to lmk if it's still in the todogroup fork and I can take a look.

Thanks! We'll update it first and ping you if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants