-
Notifications
You must be signed in to change notification settings - Fork 1
Add QuIC Organization Repolinter Action #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey Aaron, looks like the repolint file we have isn't compatible with the newer versions. I'll get it updated and passing, and then enable this action. Thanks! |
|
👍 Thank you! |
Change-Id: I2e28dc2002fea188a20b8947d3f8a508f5986caf Signed-off-by: Nasser Grainawi <quic_nasserg@quicinc.com>
1ecbfc9 to
f9bc2f8
Compare
|
@aaronkjones not sure why the repolinter action is failing. It works fine for me locally with: docker run -t -v $PWD:/src -w /src ghcr.io/todogroup/repolinter:v0.11.1 Any ideas? |
Maybe the repolinter in the GH Action version doesn't match v0.11.1 from the docker image. @prototypicalpro should we be using the fork in todogroup now? |
|
@nasser-quicinc it looks like our default ruleset has this rule turned off https://github.com/quic/.github/blob/main/repolint.json#L309 But it appears yours is set to Given the other rules that already check for license files and headers, etc., we should just disable it for now here as well. |
|
@mynameistechno You should use the todogroup fork as it has the most up to date version of repolinter (the newrelic version is still using the newrelic repolinter fork, which isn't maintained). I haven't seen that bug before, however, so feel free to lmk if it's still in the todogroup fork and I can take a look. |
Thanks! We'll update it first and ping you if necessary. |

This pull request will add the QuIC Organization Repolinter Action. Please see https://github.com/quic/.github for more information.