removed redundancies from QEFFHybridCache #582
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Onkar Chougule <ochougul@qti.qualcomm.com>
ochougul
requested review from
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
quic-rishinr
reviewed
Nov 4, 2025
| # Original Gather | ||
| ctx_len = self.key_cache[layer_idx].shape[2] | ||
| ctx_indices = torch.arange(ctx_len)[None, None, ...] | ||
| gather_limit = kv_position_ids.max(1, keepdim=True).values.unsqueeze(1) |
Contributor
There was a problem hiding this comment.
if we are using position_ids it would go overboard for sliding window right?
Contributor
Author
There was a problem hiding this comment.
yes and it won't affect the ctx_indices, there will be no invalid values in that case
Contributor
|
These changes has been taken in #616 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should improve perf for models that use sliding window like gemma, mistral etc.