Skip to content

Fixed QNN data format config issue. #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shubhagr-qc
Copy link
Contributor

Generating data format config file fails for encoder onnx graph without past key or past value.
Fixed a coding bug in the function.

Generating data format config file fails for encoder onnx graph without past key or past value.
Fixed a coding bug in the function.

Signed-off-by: Shubham Agrawal <shubhagr@qti.qualcomm.com>
@shubhagr-qc shubhagr-qc force-pushed the dataFormatConfigFix branch from 24ba6a2 to ebd6d8d Compare June 24, 2025 09:34
Signed-off-by: Shubham Agrawal <shubhagr@qti.qualcomm.com>
@ochougul
Copy link
Contributor

which model does this apply to?

@shubhagr-qc
Copy link
Contributor Author

shubhagr-qc commented Jun 25, 2025

which model does this apply to?
@ochougul During Llama4 validation for QNN, SIT team has reported this issue. It was a bug in the script where kv_overrides should be defined outside the if condition. But it was never caught, since so far all the tested configs have hit the If condition and kv_overrides was defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants