[QEff Finetune] : Made fixes to training script #439
+378
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-mamta
requested review from
quic-rishinr,
ochougul,
quic-hemagnih and
quic-amitraj
as code owners
quic-mamta
commented
Jun 10, 2025
|
|
||
|
|
||
| def get_preprocessed_samsum(dataset_config, tokenizer, split, context_length=None): | ||
| dataset = datasets.load_dataset("Samsung/samsum", split=split, trust_remote_code=True) | ||
| dataset = datasets.load_dataset("knkarthick/samsum", split=split, trust_remote_code=True) |
There was a problem hiding this comment.
Please check if this dataset can be used.
There was a problem hiding this comment.
We are not distributing this dataset hence, it should not be a problem.
quic-mamta
force-pushed
the
jitender_fixes
branch
2 times, most recently
from
6d833cf to
d269d0c
Compare
quic-mamta
changed the title
quic-mamta
assigned
quic-mamta and
quic-meetkuma and unassigned
quic-mamta and
quic-meetkuma
quic-swatia
reviewed
Jun 16, 2025
| @@ -235,11 +241,23 @@ def train( | |||
| train_step_metric.append(step_metric_val) | |||
|
|
|||
| if train_config.grad_scaler: | |||
| scaler.scale(loss).backward() # backward pass | |||
| if train_config.enable_ddp: | |||
| with model.no_sync(): | |||
There was a problem hiding this comment.
This will result in no syncing of gradients at any step.
There was a problem hiding this comment.
Yes, correct. Removed this no_sync change from this PR. We will raise separate PR for that.
| if train_config.enable_ddp: | ||
| # FIXME: We can not stop transfer of gradient across devices every time. | ||
| # In grad accumulation last step should transfer gradients across devices. | ||
| with model.no_sync(): |
There was a problem hiding this comment.
This will result in no syncing of gradients at any step here as well.
There was a problem hiding this comment.
Yes, correct. Removed this no_sync change from this PR. We will raise separate PR for that.
Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
quic-meetkuma
force-pushed
the
jitender_fixes
branch
from
12e48a9 to
085052e
Compare
…ght parameter to make the loss for padded samples as zero. Signed-off-by: Meet Patel <meetkuma@qti.qualcomm.com>
Signed-off-by: Meet Patel <meetkuma@qti.qualcomm.com>
Signed-off-by: Meet Patel <meetkuma@qti.qualcomm.com>
Signed-off-by: Meet Patel <meetkuma@qti.qualcomm.com>
…well. Signed-off-by: Meet Patel <meetkuma@qti.qualcomm.com>
… and zero the loss for padded samples. Signed-off-by: Meet Patel <meetkuma@qti.qualcomm.com>
Signed-off-by: Meet Patel <meetkuma@qti.qualcomm.com>
quic-meetkuma
force-pushed
the
jitender_fixes
branch
from
085052e to
21eb82d
Compare
Signed-off-by: Meet Patel <meetkuma@qti.qualcomm.com>
quic-meetkuma
force-pushed
the
jitender_fixes
branch
from
dfa26af to
19697d0
Compare
…e loss fn. Signed-off-by: Meet Patel <meetkuma@qti.qualcomm.com>
quic-meetkuma
force-pushed
the
jitender_fixes
branch
from
dde5ebb to
eee5328
Compare
Signed-off-by: Meet Patel <meetkuma@qti.qualcomm.com>
quic-meetkuma
force-pushed
the
jitender_fixes
branch
from
07b5f70 to
7f5f3b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below are the numbers with this PR:
Dataset: Samsum
Model: Llama-3.2-1B
Epoch: 1
Dataset: Samsum
Model: Llama-3.1-8B
Epoch: 1