Repository navigation
Schema: enhance table filter to search table and column names with safe in-memory auto-expansion - #477
Closed
HVbajoria wants to merge 1 commit into
Closed
Schema: enhance table filter to search table and column names with safe in-memory auto-expansion#477HVbajoria wants to merge 1 commit into
HVbajoria wants to merge 1 commit into
Conversation
Author
|
Resolves #331 |
Contributor
|
cc @emrberk |
Member
Closing the PR as it's overly AI-driven and unrefined. |
Author
|
Sorry for the issue @emrberk Should I create one more PR with proper details. Since, t was my first time creating a detailed PR thought of using AI for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhanced the table filter in the Schema panel to search both table names and column names. When a column matches the search query, the table automatically expands (in-memory only) to show the matching columns.
Changes
Implementation Details
allColumnsfrom the Redux store (already fetched viainformation_schema.columns()); no additional network requests.tablesWithColumnMatchesSet: Computed viauseMemoto track which tables need auto-expansion.node.isExpanded = truedirectly on tree nodes without callingsetSectionExpanded()(which writes tolocalStorage).Behavior
Testing
Tested with sample tables containing columns like col_string, col_ts, sensor_id:
Video
Screen.Recording.2025-10-02.at.1.05.57.AM.mp4