Skip to content

fix(web-console): don't use navigator.clipboard in insecure context #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

emrberk
Copy link
Contributor

@emrberk emrberk commented Apr 14, 2025

Fixes questdb/questdb#5570, we should not try to access the navigator.clipboard in insecure context (e.g. custom domain name in localhost, using http).

@emrberk emrberk requested a review from bluestreak01 April 14, 2025 10:14
@emrberk emrberk changed the title Don't use navigator.clipboard in insecure context fix(web-console): don't use navigator.clipboard in insecure context Apr 14, 2025
@javier javier self-requested a review April 14, 2025 10:50
Copy link

@javier javier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both using IP like 192.168.1.50:9999 and javier:9999 and it works in both cases. It was failing with the web console bundled with 8.2.3

@javier javier merged commit 38c4279 into main Apr 14, 2025
4 checks passed
@javier javier deleted the clipboard-secure-context branch April 14, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot copy schema for table
2 participants