fix(web-console): remove file separator symbol from queryRaw result#18
fix(web-console): remove file separator symbol from queryRaw result#18argshook wants to merge 1 commit into
queryRaw result#18Conversation
QuestDB might return data which can include non printing symbols, like [File Separator](https://unicode-table.com/en/001C/) Such symbol is not a valid token for `JSON.parse`, so code like `JSON.parse(stringWithFileSeparatorSymbol)` breaks This change simply removes that symbol. It is a non-printing symbol so it should not be displayed in the web console grid anyway.
|
Maybe it's better for us to remove illegal chars on the server side? This way not only Web Console, but any HTTP API client would be able to parse the result set. @bziobrowski WDYT? I'd also propose checking other potentially problematic chars (maybe codepoints U+D800 to U+DFFF? something else?) |
me and @bziobrowski had a two sentence discussion about removing such symbols on server, but concluded that QuestDB should not do that, as strings can contain arbitrary symbols. Removing things might be unexpected by the user. On the other hand, since web console only previews data, any non-printing chars can be removed here. |
|
Closing PR because I added nonprintable char encoding in JSON responses returned by backend . |
bziobrowski
deleted the
web-console/remove-file-separator-symbol-from-query-result
branch
3 participants
QuestDB might return data which can include non printing symbols, like
File Separator
Such symbol is not a valid token for
JSON.parse, so code likeJSON.parse(stringWithFileSeparatorSymbol)breaksThis change simply removes that symbol. It is a non-printing symbol so
it should not be displayed in the web console grid anyway.