wip test for error range#1
Merged
Merged
Conversation
emrberk
added a commit
that referenced
this pull request
Jul 9, 2026
…tch (phase 5) Lands phase 5 additively on top of the #1 supersede fix and the phase-6 sweep, reconciled so both survive. - NotebookController -> { bufferId, kind, mutate, readView, runCell }; drop the named ops and makeNotebookControllerOps; dispatch builds a transition and calls withBoundNotebook(ctrl.mutate) / readView directly - strip ModelToolsClient to the quest + workspace surface; delete the isLiveController pre-checks (validation already lives in the transitions) - move read serializers into notebookSnapshot; buildSnapshot reads via readView - preserve the live runCell CellRunOutcome/superseded reporting from the #1 fix in the collapsed wrapper, plus its re-homed unknown_cell guard - keep the sweep's NotebookToolError source import and the dropped activate knob Original phase-5 authored on machine A; reconciled onto origin here. Co-Authored-By: emrberk <emreberk5699@gmail.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KQfYWS6dFLNBxZ2ncyTNyW
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.