Fix Shift+F1 settings, PR diff file list, and F3 on ".."#18
Merged
bluestreak01 merged 1 commit intomasterfrom Apr 15, 2026
Merged
Fix Shift+F1 settings, PR diff file list, and F3 on ".."#18bluestreak01 merged 1 commit intomasterfrom
bluestreak01 merged 1 commit intomasterfrom
Conversation
- Fix PR diff showing incorrect changed files by fetching the base branch before computing the merge base - Make Shift+F1 (ToggleSettings) work from all panels by handling the action before bottom-panel dispatch in handle_action, and moving the settings dialog key mapping above the bottom-panel block in map_key_to_action - Add Shift+F1 to hex editor and diff viewer key handlers - Fix F3 on ".." to compute size of current directory (not parent), displaying the result in the size column via start_size_calc_at which separates the dir_sizes key from the scan path Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/{base_branch}beforegit diff --name-statusso the merge base is current and the changed file list matches GitHubToggleSettingsaction was swallowed by panel-specific handlers inhandle_action(Diff, CI, Claude, Shell). Fixed by dispatchingToggleSettingsbefore the bottom-panel block. Also moved the settings dialog key mapping above the bottom-panel key block so Esc/arrows work when settings is opened from a bottom panel. Added Shift+F1 to hex editor and diff viewer key handlers.handle_calc_sizenow scanscurrent_dirwhen ".." is selected, usingentry.pathas thedir_sizeskey so the result displays in the size column. Addedstart_size_calc_at(key, scan_path)to decouple the lookup key from the scan target.Test plan
gh pr diff --name-only🤖 Generated with Claude Code