Skip to content

Fix Shift+F1 settings, PR diff file list, and F3 on ".."#18

Merged
bluestreak01 merged 1 commit intomasterfrom
vi_fixup2
Apr 15, 2026
Merged

Fix Shift+F1 settings, PR diff file list, and F3 on ".."#18
bluestreak01 merged 1 commit intomasterfrom
vi_fixup2

Conversation

@bluestreak01
Copy link
Copy Markdown
Member

@bluestreak01 bluestreak01 commented Apr 15, 2026

Summary

  • PR diff stale files: Fetch origin/{base_branch} before git diff --name-status so the merge base is current and the changed file list matches GitHub
  • Shift+F1 (Settings) unreachable from bottom panels: The ToggleSettings action was swallowed by panel-specific handlers in handle_action (Diff, CI, Claude, Shell). Fixed by dispatching ToggleSettings before the bottom-panel block. Also moved the settings dialog key mapping above the bottom-panel key block so Esc/arrows work when settings is opened from a bottom panel. Added Shift+F1 to hex editor and diff viewer key handlers.
  • F3 on ".." computed parent size: handle_calc_size now scans current_dir when ".." is selected, using entry.path as the dir_sizes key so the result displays in the size column. Added start_size_calc_at(key, scan_path) to decouple the lookup key from the scan target.

Test plan

  • Open a PR branch, press Ctrl+D — verify file list matches gh pr diff --name-only
  • Press Shift+F1 from file panel, Ctrl+D panel, shell, CI panel, hex editor, diff viewer — settings dialog should open from all
  • While settings is open, verify Esc closes it and arrow keys navigate
  • Navigate to a directory, press F3 on ".." — verify current directory size appears in the size column

🤖 Generated with Claude Code

- Fix PR diff showing incorrect changed files by fetching the base
  branch before computing the merge base
- Make Shift+F1 (ToggleSettings) work from all panels by handling
  the action before bottom-panel dispatch in handle_action, and
  moving the settings dialog key mapping above the bottom-panel
  block in map_key_to_action
- Add Shift+F1 to hex editor and diff viewer key handlers
- Fix F3 on ".." to compute size of current directory (not parent),
  displaying the result in the size column via start_size_calc_at
  which separates the dir_sizes key from the scan path

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bluestreak01 bluestreak01 merged commit a02e228 into master Apr 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant