Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test: #322: disable integration tests by default #323

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

jordanw-bq
Copy link
Contributor

No description provided.

@@ -13,7 +13,7 @@ sudo: enabled
before_install:
- /bin/bash rubix_setup_build.sh
install: true
script: chmod a+x docker_build_rubix.sh && /bin/bash rubix_run_build.sh mvn integration-test -rf :rubix-tests
script: chmod a+x docker_build_rubix.sh && /bin/bash rubix_run_build.sh mvn integration-test -Pintegration-tests -rf :rubix-tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-rf :rubix-tests will only start rubix-tests module. So, Cobertura is not reporting coverage for all the other unit-tests. I think you should remove -rf :rubix-tests

Copy link
Contributor Author

@jordanw-bq jordanw-bq Aug 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cobertura coverage gets reported as a separate step, since running tests with coverage interferes with the integration tests:

if [[ -n "${TRAVIS}" ]]; then
upload-coverage-results
fi

upload-coverage-results() {
echo "=== Running tests with coverage ==="
# "cobertura-integration-test" goal needed for shading JARs
# if run on CI, integration tests will have been run before this
mvn cobertura:cobertura-integration-test -Pno-integration-tests
echo "=== Uploading code coverage results to Codecov ==="
bash <(curl -s https://codecov.io/bash)
}

We start from this module to avoid running the unit tests multiple times, which would increase the build time by 1:30-2min.

@codecov-io
Copy link

Codecov Report

Merging #323 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   50.36%   50.49%   +0.12%     
==========================================
  Files          61       61              
  Lines        3121     3131      +10     
  Branches      348      348              
==========================================
+ Hits         1572     1581       +9     
- Misses       1462     1464       +2     
+ Partials       87       86       -1
Impacted Files Coverage Δ
...om/qubole/rubix/hadoop2/Hadoop2ClusterManager.java 56.52% <0%> (-4.46%) ⬇️
.../qubole/rubix/hadoop2/Hadoop2ClusterManagerV2.java 51.61% <0%> (-1.02%) ⬇️
...rc/main/java/com/qubole/rubix/spi/ClusterType.java 46.15% <0%> (+46.15%) ⬆️

@abhishekdas99 abhishekdas99 merged commit 40e5b46 into qubole:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants