Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new:dev:Upgrade Apache Calcite to 1.13 #95

Merged
merged 13 commits into from
Jul 10, 2017
Merged

new:dev:Upgrade Apache Calcite to 1.13 #95

merged 13 commits into from
Jul 10, 2017

Conversation

vrajat
Copy link
Contributor

@vrajat vrajat commented Jul 10, 2017

The main changes are:

  • JDBC uses Avatica 1.10. The interface has changed a bit and code had to be copied over.
  • Parser required more APIs to be defined. These are empty for Quark.
  • Calcite Core has changed processing of Materialized Views and Cubes.

One major change is that it expects the RowType of Cubes to as per an algorithm. Since Quark uses grouping_id to store a cube in the same table, the RowType of a QuarkTileTable does not match the expected RowType, QuarkTileTable now return TileScan -> Filter (GroupingId) -> Project. The new plan required changes in AggStarRule and FilterAggRule including changing ordinals.

RelOptToSqlConverter by default returns non-qualified names. Since Quark requires fully qualified names, QuarkTable has a pointer to QuarkSchema. This change required interface changes and subsequent changes across all derived classes.

As part of clean up, a few bugs were unearthed. These have been fixed.

A few tests have been ignored mainly in MaterializedViewsJoinTest. It looks like these were badly setup tests.

@vrajat vrajat requested a review from amoghmargoor July 10, 2017 09:36
@vrajat vrajat merged commit f3a09a8 into qubole:master Jul 10, 2017
@vrajat vrajat deleted the upgrade-calcite branch July 10, 2017 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant