new:dev:Upgrade Apache Calcite to 1.13 #95
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are:
One major change is that it expects the RowType of Cubes to as per an algorithm. Since Quark uses
grouping_id
to store a cube in the same table, the RowType of aQuarkTileTable
does not match the expected RowType,QuarkTileTable
now returnTileScan -> Filter (GroupingId) -> Project
. The new plan required changes inAggStarRule
andFilterAggRule
including changing ordinals.RelOptToSqlConverter
by default returns non-qualified names. Since Quark requires fully qualified names,QuarkTable
has a pointer toQuarkSchema
. This change required interface changes and subsequent changes across all derived classes.As part of clean up, a few bugs were unearthed. These have been fixed.
A few tests have been ignored mainly in
MaterializedViewsJoinTest
. It looks like these were badly setup tests.