Skip to content

Commit

Permalink
SDK-344: Enable use of port argument for DbTaps #267
Browse files Browse the repository at this point in the history
  • Loading branch information
chattarajoy authored and msumit committed Mar 19, 2019
1 parent 3648855 commit 6893589
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions qds_sdk/dbtaps.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ def parsers():
help="Username")
edit.add_argument("--password", dest="password",
help="Password")
edit.add_argument("--port", dest="port",
help="Database Port")
edit.add_argument("--port", dest="port", help="Database Port")
edit.add_argument("--type", dest="type", choices=["mysql","vertica","mongo","postgresql","redshift","sqlserver"],
help="Type of database")
edit.add_argument("--location", dest="location", choices=["us-east-1", "us-west-2", "ap-southeast-1", "eu-west-1", "on-premise"],
Expand Down Expand Up @@ -107,7 +106,8 @@ def create(args):
db_user=args.user,
db_passwd=args.password,
db_type=args.type,
db_location=args.location)
db_location=args.location,
port=args.port)

return json.dumps(dbtap.attributes, sort_keys=True, indent=4)

Expand Down Expand Up @@ -148,6 +148,8 @@ def edit(args):
options["db_type"] = args.type
if args.location is not None:
options["db_location"] = args.location
if args.port is not None:
options["port"] = args.port
tap = tap.edit(**options)
return json.dumps(tap.attributes, sort_keys=True, indent=4)

Expand Down

0 comments on commit 6893589

Please sign in to comment.