Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hpa: Only deploy clair HPA when HPA component is managed (PROJQUAY-2435) #520

Merged
merged 1 commit into from
Oct 25, 2021
Merged

hpa: Only deploy clair HPA when HPA component is managed (PROJQUAY-2435) #520

merged 1 commit into from
Oct 25, 2021

Conversation

jonathankingfc
Copy link
Collaborator

  • Clair HPA is only deployed when HPA component is managed

github-actions[bot]
github-actions bot reviewed Oct 21, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://issues.redhat.com/browse/PROJQUAY-2435

ricardomaraschini
ricardomaraschini suggested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You gonna need take this change into account when reporting the HPA status condition here. Remember to also add a test case for it. You may use this as a base as it also checks for multiple objects of the same kind (deployments in this case).

@jonathankingfc
hpa: Only deploy clair HPA when HPA component is managed (PROJQUAY-2435)
d2317f0 
- Clair HPA is only deployed when HPA component is managed
ricardomaraschini
ricardomaraschini approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathankingfc jonathankingfc merged commit ae1bc5c into master Oct 25, 2021
ricardomaraschini pushed a commit that referenced this pull request Oct 26, 2021
@jonathankingfc @ricardomaraschini
hpa: Only deploy clair HPA when HPA component is managed (PROJQUAY-2435…
3c80f67 
…) (#520)

- Clair HPA is only deployed when HPA component is managed
@jonathankingfc jonathankingfc deleted the PROJQUAY-2435 branch October 27, 2021 12:43
ricardomaraschini pushed a commit that referenced this pull request Oct 28, 2021
@jonathankingfc @ricardomaraschini
hpa: Only deploy clair HPA when HPA component is managed (PROJQUAY-2435…
a2d08d8 
…) (#520)

- Clair HPA is only deployed when HPA component is managed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ricardomaraschini ricardomaraschini ricardomaraschini approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathankingfc @ricardomaraschini