tls: executing pod termination (PROJQUAY-2428) #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
reviewed
Sep 14, 2021
| } | ||
| if quayComponentLabel == "quay-app-route" { | ||
| rt.Spec.Port = &route.RoutePort{ | ||
| TargetPort: intstr.Parse("https"), |
There was a problem hiding this comment.
I'm not sure I 100% understand this, intstr.Parse() is going to create an object whose String() method will return "https" and whose IntValue() method will return 0?
There was a problem hiding this comment.
Yeah, it is a struct (intstr.IntOrString) used by k8s when a field may be an int or a string (like the port).
| fieldGroup := &hostsettings.HostSettingsFieldGroup{ | ||
| ExternalTlsTermination: true, | ||
| ExternalTlsTermination: terminateExternally, | ||
| PreferredUrlScheme: "https", |
There was a problem hiding this comment.
Should this also be switched on whether or not we are terminating externally?
There was a problem hiding this comment.
As we checked, it seems like we don't need it to be switched to http.
If TLS is unmanaged we expect the user to provide its own cert and key. This PR changes the route to 'passthrough' and mounts the certificates inside quay pod if TLS is unmanaged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If TLS is unmanaged we expect the user to provide its own cert and key.
This PR changes the route to 'passthrough' and mounts the certificates
inside quay pod if TLS is unmanaged.