database: avoid regenerating password (PROJQUAY-2319) #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proceed to store database root password the same way we do for the DB_URI. By doing that we avoid postgres redeployment during every reconcile cycle.
crozzy
approved these changes
Aug 24, 2021
| @@ -324,7 +333,7 @@ func KustomizationFor(ctx *quaycontext.QuayRegistryContext, quay *v1.QuayRegistr | |||
| componentPaths = append(componentPaths, filepath.Join("..", "components", string(component.Kind))) | |||
| managedFieldGroups = append(managedFieldGroups, fieldGroupNameFor(component.Kind)) | |||
|
|
|||
| componentConfigFiles, err := componentConfigFilesFor(component.Kind, quay, quayConfigFiles) | |||
| componentConfigFiles, err := componentConfigFilesFor(ctx, component.Kind, quay, quayConfigFiles) | |||
There was a problem hiding this comment.
Nit: Maybe a different name here would be a good idea, ctx is traditionally always context.Context. qCtx or quayCtx might distinguish it more.
There was a problem hiding this comment.
Following pre established standards here. I fully agree with you.
| @@ -264,6 +264,14 @@ func KustomizationFor(ctx *quaycontext.QuayRegistryContext, quay *v1.QuayRegistr | |||
| return nil, err | |||
| } | |||
|
|
|||
| if ctx.DbRootPw == "" { | |||
| rootpw, err := generateRandomString(32) | |||
There was a problem hiding this comment.
Nit: maybe rootPw to be consistent with the rest of the PR
There was a problem hiding this comment.
Yes, you are right. This was a copy and paste from a branch where I am working in refactoring this. I guess we can live with this until we land that other PR of mine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proceed to store database root password the same way we do for the
DB_URI. By doing that we avoid postgres redeployment during every
reconcile cycle.