pullsecret: global pullsecrets (PROJQUAY-1603) #70
Conversation
image/image.go
Outdated
| secretData := secret.Data[strings.ReplaceAll(string(secret.Type), "kubernetes.io/", ".")] | ||
|
|
||
| var config *DockerConfigJson | ||
| if err = json.Unmarshal(secretData, &config); err != nil { |
There was a problem hiding this comment.
kubernetes.io/dockerconfigjson and kubernetes.io/dockercfg have different structure. One of them looks like {"auths":{"example.com":...}}, another one like {"example.com":...}
There was a problem hiding this comment.
That came through my mind. I have chosen not to change this to avoid breaking other stuff. In other words: the code you are referring to here is the very same code that was already there prior to my change. The other format was never supported.
There was a problem hiding this comment.
I have added support for the SecretTypeDockercfg type as well. PTAL.
/cc @kleesc would you mind checking it once more ?
Add support for OpenShift global pull secret. This secret exists in the "openshift-config" namespace and is called "pull-secret". We attempt to use it if we can't find credentials in the pod's namespace.
Added support for kubernetes secrets of type SecretTypeDockercfg.
|
/cherry-pick redhat-3.7 |
|
@HammerMeetNail: #70 failed to apply on top of branch "redhat-3.7": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick redhat-3.7 |
|
@ricardomaraschini: new pull request created: #76 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add support for OpenShift global pull secret. This secret exists in the
"openshift-config" namespace and is called "pull-secret". We attempt to
use it if we can't find credentials in the pod's namespace.