This repository was archived by the owner on Jul 30, 2026. It is now read-only.
fix: resolve layer URLs at fetch time - #286
Merged
Merged
Conversation
hdonnay
reviewed
Jul 9, 2026
| URI: res.Request.URL.String(), | ||
| Headers: res.Request.Header, | ||
| Hash: ccd, | ||
| URI: u.String(), |
Member
There was a problem hiding this comment.
To do this, you need add the auth headers. The point of "resolving" the URL is to not have to do that, but it does start any URL auth timer ticking when that's done.
Contributor
Author
There was a problem hiding this comment.
The auth headers are set in http client's transport. Is that a problem? Maybe there's something I'm not seeing (security issue perhaps?)
Contributor
Author
|
OBE |
ManifestFromRemote captured presigned blob URLs for every layer before any downloading began; on images with large layers the URLs for later layers expired (typically after 10 minutes) before the fetcher reached them. Store the registry's stable blob URL instead and hand the authenticated transport to the fetch arena, so each layer GET authenticates fresh and follows the storage redirect immediately. Fixes quay#275 Signed-off-by: Brad Lugo <brad@bradlugo.com>
hdonnay
force-pushed
the
fetch-time-layer-urls
branch
from
July 23, 2026 21:25
1f00a6c to
855cb2f
Compare
hdonnay
approved these changes
Jul 23, 2026
Member
|
/fast-forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ManifestFromRemote captured presigned blob URLs for every layer before any downloading began; on images with large layers the URLs for later layers expired (typically after 10 minutes) before the fetcher reached them. Store the registry's stable blob URL instead and hand the authenticated transport to the fetch arena, so each layer GET authenticates fresh and follows the storage redirect immediately.
Fixes #275