panlint: Add option to exit cleanly even if problems are found #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrha
changed the title
stdweird
reviewed
Jul 13, 2017
| @@ -448,6 +448,7 @@ def main(): | |||
| parser.add_argument('--vi', action='store_true', help='Output line numbers in a vi option style') | |||
| parser.add_argument('--table', action='store_true', help='Display a table of per-file problem stats') | |||
| parser.add_argument('--allow_mvn_templates', action='store_true', help='Allow use of maven templates') | |||
| parser.add_argument('--ignore_problems_on_exit', action='store_true', help='Exit cleanly even if problems are found') | |||
There was a problem hiding this comment.
i would rename it to always_exit_success, because this is what your code does
ned21
reviewed
Jul 13, 2017
| @@ -465,7 +466,7 @@ def main(): | |||
|
|
|||
| if not args.paths: | |||
| print 'No files were provided, not doing anything' | |||
| sys_exit(0) | |||
| return 0 | |||
There was a problem hiding this comment.
IMHO this is a (user) error. Since the user ran the tool they wanted an effect, unless they passed --help or -v or something.
jrha
force-pushed
the
panlint
branch
2 times, most recently
from
69a982e
to
9d70a3f
Compare
|
@stdweird thanks for the suggestion — done |
stdweird
reviewed
Jul 24, 2017
| @@ -485,6 +486,9 @@ def main(): | |||
| print '%d problems found in total' % problems_found | |||
|
|
|||
| if args.ignore_problems_on_exit: | |||
There was a problem hiding this comment.
you changed the option name, but not the attribute name?
Some testing frameworks interpret tools exiting with a non-zero code as a failure of the tool rather than the tests it performs, adding this option allows panlint to be used with these tools. (e.g. arcanist).
stdweird
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some testing frameworks interpret tools exiting with a non-zero code as a
failure of the tool rather than the tests it performs, adding this option
allows panlint to be used with these tools. (e.g. arcanist).