Skip to content

Fix problems with nested components when opening a custom dialog (fix #18159) #18160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+8 −14
Open

Fix problems with nested components when opening a custom dialog (fix #18159) #18160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions ui/src/utils/private.dialog/create-dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,15 @@ export default function (DefaultComponent, supportsCustomComponent, parentApp) {
const target = vm.$.subTree

if (target?.component) {
// account for "script setup" way of declaring component
if (target.component.proxy && target.component.proxy[ cmd ]) {
target.component.proxy[ cmd ]()
return
}
let currentComponent = target.component

while (currentComponent) {
if (currentComponent.proxy && currentComponent.proxy[ cmd ]) {
currentComponent.proxy[ cmd ]()
return
}

// account for "script setup" + async component way of declaring component
if (
target.component.subTree
&& target.component.subTree.component
&& target.component.subTree.component.proxy
&& target.component.subTree.component.proxy[ cmd ]
) {
target.component.subTree.component.proxy[ cmd ]()
return
currentComponent = currentComponent.subTree?.component
}
}

Expand Down