Skip to content

Conversation

@Bosphoramus
Copy link
Contributor

@Bosphoramus Bosphoramus commented Mar 25, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:
This PR fixes the Vue warning:

Avoid app logic that relies on enumerating keys on a component instance. The keys will be empty in production mode to avoid the performance overhead.

… component instance. The keys will be empty in production mode to avoid performance overhead.)
@Bosphoramus
Copy link
Contributor Author

Issue link

@yusufkandemir yusufkandemir changed the title Fixing Vue warn (Avoid app logic that relies on enumerating keys on a… fix: #12936 fix(app-webpack): Avoid Vue "enumaration" warning when using router inside Pinia (fix: #12936) Mar 25, 2022
@yusufkandemir yusufkandemir changed the title fix(app-webpack): Avoid Vue "enumaration" warning when using router inside Pinia (fix: #12936) fix(app-vite&app-webpack): Avoid Vue "enumaration" warning when using router inside Pinia (fix: #12936) Mar 25, 2022
@yusufkandemir yusufkandemir merged commit f986c6f into quasarframework:dev Mar 25, 2022
@yusufkandemir
Copy link
Member

Thanks for contributing! 👏

@Bosphoramus
Copy link
Contributor Author

Bosphoramus commented Mar 25, 2022

@yusufkandemir oh, i also adjusted the app-vite file, but it didnt get commited for some reason 😅
Thank you for editing it yourself

@Bosphoramus
Copy link
Contributor Author

Thanks for contributing! 👏

Thanks to you :)

@rstoenescu
Copy link
Member

Thanks for contributing!
Improved this a bit. Rather than executing the markRaw for each store, marked it as raw from the get-go. While at it, it actually is better to also do this for Vuex too.

@rstoenescu
Copy link
Member

Also, going to change the default store code - by eliminating the arrow keys so "this" can point to the right thing.

@Bosphoramus
Copy link
Contributor Author

@rstoenescu perfect! Thank you 😊

@Bosphoramus
Copy link
Contributor Author

Hope all this is released soon haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants