Fix #7701 with "noSelectionUnset" QTree can't emit null #12055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I changed the checks a bit, going back to my previous version (#12012). Because in your version it was impossible emit null (nothing happens if you click on the root element with key = null, after any other selected. if you click any element - you can't click back the root).
My if-else check for two options.
First, the old behavior always emits the value, as in the old logic, if there is no new option (when noSelectionUnset = false).
Otherwise, emit any value only if it has changed (when noSelectionUnset = true, new behavior).
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes: