feat(touch events): use passive mode in more cases #12822 (#14474)

* feat(touch events): use passive mode in more cases #12822 * Update TouchPan.js * Update TouchSwipe.js Co-authored-by: Razvan Stoenescu <razvan.stoenescu@gmail.com>
quasarframework · Oct 1, 2022 · cebd845 · cebd845
1 parent 5221ac1
commit cebd845
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/ui/src/components/btn/QBtn.js b/ui/src/components/btn/QBtn.js
@@ -69,7 +69,7 @@ export default Vue.extend({
         }
 
         if (this.$q.platform.has.touch === true) {
-          on.touchstart = this.__onTouchstart
+          on[ `${on.touchstart === void 0 ? '&' : ''}touchstart` ] = this.__onTouchstart
         }
 
         return on

diff --git a/ui/src/directives/TouchHold.js b/ui/src/directives/TouchHold.js
@@ -145,7 +145,7 @@ export default {
 
     client.has.touch === true && addEvt(ctx, 'main', [
       [ el, 'touchstart', 'touchStart', `passive${modifiers.capture === true ? 'Capture' : ''}` ],
-      [ el, 'touchend', 'noop', 'notPassiveCapture' ]
+      [ el, 'touchend', 'noop', 'passiveCapture' ]
     ])
   },
 

diff --git a/ui/src/directives/TouchPan.js b/ui/src/directives/TouchPan.js
@@ -392,7 +392,7 @@ export default {
 
     client.has.touch === true && addEvt(ctx, 'main', [
       [ el, 'touchstart', 'touchStart', `passive${modifiers.capture === true ? 'Capture' : ''}` ],
-      [ el, 'touchmove', 'noop', 'notPassiveCapture' ]
+      [ el, 'touchmove', 'noop', 'notPassiveCapture' ] // cannot be passive (ex: iOS scroll)
     ])
   },
 

diff --git a/ui/src/directives/TouchRepeat.js b/ui/src/directives/TouchRepeat.js
@@ -223,7 +223,7 @@ export default {
 
     client.has.touch === true && addEvt(ctx, 'main', [
       [ el, 'touchstart', 'touchStart', `passive${modifiers.capture === true ? 'Capture' : ''}` ],
-      [ el, 'touchend', 'noop', 'notPassiveCapture' ]
+      [ el, 'touchend', 'noop', 'passiveCapture' ]
     ])
 
     keyboard.length > 0 && addEvt(ctx, 'main', [

diff --git a/ui/src/directives/TouchSwipe.js b/ui/src/directives/TouchSwipe.js
@@ -250,7 +250,7 @@ export default {
 
     client.has.touch === true && addEvt(ctx, 'main', [
       [ el, 'touchstart', 'touchStart', `passive${modifiers.capture === true ? 'Capture' : ''}` ],
-      [ el, 'touchmove', 'noop', 'notPassiveCapture' ]
+      [ el, 'touchmove', 'noop', 'notPassiveCapture' ] // cannot be passive (ex: iOS scroll)
     ])
   },