-
Notifications
You must be signed in to change notification settings - Fork 44
feat(snowflake): alter network policy' #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
benfdking
commented
Sep 17, 2025
- feat(snowflake): resource monitor statements
- feat(snowflake): alter procedure snowflake
- feat(snowflake): alter account statement
- feat(snowflake): implement the alter database
- feat(snowflake): improve create table defaults
- feat(snowflake): alter masking policy
- feat(snowflake): alter network policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments
to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
// An `ALTER RESOURCE MONITOR` statement. | ||
// https://docs.snowflake.com/en/sql-reference/sql/alter-resource-monitor | ||
"AlterResourceMonitorStatementSegment".into(), | ||
Sequence::new(vec_of_erased![ | ||
Ref::keyword("ALTER"), | ||
Sequence::new(vec_of_erased![ | ||
Ref::keyword("RESOURCE"), | ||
Ref::keyword("MONITOR"), | ||
]), | ||
Ref::new("IfExistsGrammar").optional(), | ||
Ref::new("ObjectReferenceSegment"), | ||
Ref::keyword("SET"), | ||
Ref::new("ResourceMonitorOptionsSegment"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Allow ALTER RESOURCE MONITOR to suspend or resume
The new AlterResourceMonitorStatementSegment
only accepts the SET
variant (ALTER RESOURCE MONITOR … SET …
). Snowflake’s grammar also allows control commands such as ALTER RESOURCE MONITOR my_monitor RESUME
, … SUSPEND
, and … SUSPEND IMMEDIATE
. With the current matcher these valid statements will be rejected as syntax errors. The parser should include these action alternatives alongside the SET
clause so resource monitors can be paused or resumed.
Useful? React with 👍 / 👎.