Skip to content

Conversation

benfdking
Copy link
Collaborator

  • feat(snowflake): resource monitor statements
  • feat(snowflake): alter procedure snowflake
  • feat(snowflake): alter account statement
  • feat(snowflake): implement the alter database
  • feat(snowflake): improve create table defaults
  • feat(snowflake): alter masking policy
  • feat(snowflake): alter network policy

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +7941 to +7953
// An `ALTER RESOURCE MONITOR` statement.
// https://docs.snowflake.com/en/sql-reference/sql/alter-resource-monitor
"AlterResourceMonitorStatementSegment".into(),
Sequence::new(vec_of_erased![
Ref::keyword("ALTER"),
Sequence::new(vec_of_erased![
Ref::keyword("RESOURCE"),
Ref::keyword("MONITOR"),
]),
Ref::new("IfExistsGrammar").optional(),
Ref::new("ObjectReferenceSegment"),
Ref::keyword("SET"),
Ref::new("ResourceMonitorOptionsSegment"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Allow ALTER RESOURCE MONITOR to suspend or resume

The new AlterResourceMonitorStatementSegment only accepts the SET variant (ALTER RESOURCE MONITOR … SET …). Snowflake’s grammar also allows control commands such as ALTER RESOURCE MONITOR my_monitor RESUME, … SUSPEND, and … SUSPEND IMMEDIATE. With the current matcher these valid statements will be rejected as syntax errors. The parser should include these action alternatives alongside the SET clause so resource monitors can be paused or resumed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant