Skip to content

Add "insert code cell" to editor action bar #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

juliasilge
Copy link
Collaborator

Addresses posit-dev/positron#3923

This first go at this puts the new button on the right, includes the label, and uses the "insert" icon:

Screenshot 2025-05-17 at 5 19 56 PM

We can't fit it on the left, since adding it there pushes "editor/actions/left" to past the center mark, and the labels don't all fit and get borked. We may want to change how the labels on the editor action bar behave when they run out of space.

  • Do we want to include the label? RStudio does not and seems like folks know how to use it.
  • Do we want to use this "insert" icon? Another option would be the "plus" icon, or making a new one.

"editor/actions/right": [
{
"command": "quarto.insertCodeCell",
"when": "editorLangId == quarto",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this in the Visual Editor (it has its own bar that includes inserting a code cell) or markdown files (executable code cells don't do anything in .md).

@juliasilge juliasilge requested a review from softwarenerd May 17, 2025 23:31
Copy link
Contributor

@softwarenerd softwarenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Sorry I spaced out on reviewing this. I was out sick on Monday and I lost track of the work item.

@juliasilge juliasilge merged commit b45f12e into main May 22, 2025
1 check passed
@juliasilge juliasilge deleted the add-insert-to-editor-action-bar branch May 22, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants