Add option to use theme provided cell background (#675) #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Thank you again so much for this contribution and your willingness to iterate on it, @kylebutts! ❤️
This is working great for me and looks good in the settings UI:
I also added a deprecation warning for the old setting, to hopefully help any folks who did set it away from the default:
|
@kylebutts we'll do a release fairly soon for the Quarto extension, but if you want to use this in the meantime, I think the easiest thing to do is get the artifact from this GH action run, unzip it, and then "Install from VSIX" in VS Code or Positron: https://github.com/quarto-dev/quarto/actions/runs/13796690796 |
This was referenced Mar 12, 2025
|
Fixing the deprecated setting name in #680 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates configuration for cell background color. See #677 for discussion.
Updates:
quarto.cells.background.enabled->quarto.cells.background.colorwhich now has three options:"default","off", and"useTheme".useThemewill use thenotebook.selectedCellBackgroundcolor from the VS Code theme.Renamed default color options:
quarto.cells.background.light->quarto.cells.background.lightDefaultandquarto.cells.background.dark->quarto.cells.background.darkDefault