-
Notifications
You must be signed in to change notification settings - Fork 994
Add context and new example to redirects doc #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original text here provided two example use cases. The following sentence began with "For this use case" and provided a example code for the latter one. This change provides example code for both use cases.
Collaborator
|
/deploy-preview |
Contributor
|
🚀 Deployed on https://deploy-preview-1652.quarto.org |
Collaborator
|
/deploy-preview |
Contributor
|
🚀 Deployed on https://deploy-preview-1652.quarto.org |
Collaborator
|
@mfisher87 Thanks for this! It was a good idea to clarify these examples |
github-actions bot
pushed a commit
that referenced
this pull request
May 6, 2025
* Add callout explaining why redirects use `.html` extension * Add example for re-organizing directory hierarchy The original text here provided two example use cases. The following sentence began with "For this use case" and provided a example code for the latter one. This change provides example code for both use cases. * Wording edits --------- Co-authored-by: Charlotte Wickham <cwickham@gmail.com> (cherry picked from commit fa1c9bd)
Contributor
|
Successfully created backport PR for |
Contributor
Author
|
Happy to help, thanks for offering additional clarity in your edits :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all, I was reading the redirects doc and felt some additional context could be added to help users better understand why they need to write their config the way they do. I also felt that it would be valuable to have an explicit example for each of the use cases mentioned in the doc, so I added an example for re-organizing directory hierarchy.