Add param profile to quarto_inspect() and quarto_render()
#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salim-b
changed the title
profile to quarto_inspect()profile to quarto_inspect() and quarto_render()
This reverts commit daa5f05. We'll handle arg check improvement separately in another PR.
cderv
reviewed
Oct 13, 2023
Collaborator
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
Thanks. I'll do some tweaks and merge
Collaborator
There was a problem hiding this comment.
I think I will handle the arg check improvement separately. I want to add test as is before. Thanks
cderv
approved these changes
Oct 13, 2023
Collaborator
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
Thanks. I'll do some tweaks and merge
[skip ci]
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes
quarto_render()arg checks more robust (for the case where aNULLvalue is explicitly supplied).Note that
profileisn't checked for validity/existence, but forwarded 1:1 toquarto inspect --profile. This means that if aprofileis specified that doesn't exist, Quarto silently falls back to the default profile.Fixes #95.