Skip to content

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Jan 24, 2024

This really 1.4 missing feature for new quarto use binder https://quarto.org/docs/projects/binder.html

but maybe too late to merge. I let you decide. It seems small enough though...

@dragonstyle dragonstyle merged commit 169b088 into main Jan 24, 2024
@dragonstyle dragonstyle deleted the binder-no-prompt branch January 24, 2024 21:53
@cderv
Copy link
Collaborator Author

cderv commented Jan 24, 2024

Thanks !

Do we backport this to 1.4 or not ?

Just to know if I include it into the R package and on what condition

@dragonstyle
Copy link
Collaborator

I think I would personally be ok back porting just because the change is so small / safe.

I do think that in general, configuring Binder is sufficiently complex that doing so non-interactively does seem like more of an edge case (until we add this support in r package, that is!)

@dragonstyle dragonstyle added the needs-discussion Issues that require a team-wide discussion before proceeding further label Jan 24, 2024
@cderv
Copy link
Collaborator Author

cderv commented Jan 25, 2024

I do think that in general, configuring Binder is sufficiently complex that doing so non-interactively does seem like more of an edge case (until we add this support in r package, that is!)

I agree with that. I was hesitant to add it in the R package, but it felt easy enough, until I hit this blocker.
Situation is :

  • Either it will be in 1.5 and I need to conditionally stop execution if quarto version used with R is < 1.5
  • Either it is in 1.4 patch, and I need to check the version too, with minor version
  • Or we don't add it at all in the R package - that would be ok too.

Only reason I am asking. I am fine with 1.5 too - easy enough to add it like and see if some R users are asking / using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-discussion Issues that require a team-wide discussion before proceeding further

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants