Skip to content

Add auto completion for giscus themes on each ligth / dark configuration#8344

Merged
dragonstyle merged 1 commit intomainfrom
giscus/night-theme-description
Jan 19, 2024
Merged

Add auto completion for giscus themes on each ligth / dark configuration#8344
dragonstyle merged 1 commit intomainfrom
giscus/night-theme-description

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Jan 18, 2024

Opening PR to test this through our schema validation

@cderv
Copy link
Collaborator Author

cderv commented Jan 18, 2024

Yeah it is working !

image

So cool ! Great schema design ! 🤯 It was in fact so simple !

@cderv cderv marked this pull request as ready for review January 18, 2024 17:16
@cderv cderv linked an issue Jan 18, 2024 that may be closed by this pull request
1 task
@cderv cderv added this to the v1.4 milestone Jan 18, 2024
@cderv cderv requested a review from cscheid January 18, 2024 17:16
@dragonstyle dragonstyle merged commit f571754 into main Jan 19, 2024
@dragonstyle dragonstyle deleted the giscus/night-theme-description branch January 19, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.4 Changelog Updates: Giscus light/dark themes

2 participants