Attributes are passed through in Title when using empty heading#8018
Merged
Attributes are passed through in Title when using empty heading#8018
Conversation
dragonstyle
approved these changes
Jan 2, 2024
Collaborator
dragonstyle
left a comment
There was a problem hiding this comment.
This looks good to me. I confirmed that Pandoc does parse ## {.foo} as a heading with attributes/classes as you'd expect so we appear to be handling this incorrectly in its current form.
d9ce737 to
ff8199d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8012 report (solves part of it)
We should consider empty headers with attributes when matching against Pandoc Title regex
Dummy example
It context of revealjs, this is a problem has empty headers can have a meaning (creating a new section without title)