Resolve user paths before mergin template partials#8007
Merged
dragonstyle merged 1 commit intomainfrom Dec 21, 2023
Merged
Conversation
Collaborator
Author
|
Opening to watch tests |
Since we are merging absolute paths to format resources into the partials provided by the user, we need to resolve the user paths into absolute paths before we merge them. This will allow us to to use project semantics for resolving the path - (e.g. `/` prefix path).
dragonstyle
force-pushed
the
bugfix/temp-part
branch
from
a9166e1 to
4202ea5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are merging absolute paths to format resources into the partials provided by the user, we need to resolve the user paths into absolute paths before we merge them. This will allow us to to use project semantics for resolving the path - (e.g.
/prefix path).