-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to pandoc 3.1.11 and typst 0.10.0 #7914
Conversation
Just FYI, If you're talking about the image sizing workaround, then my understanding is that the Pandoc fix for that doesn't currently solve the problem, so we need to keep that for a bit longer. |
I did revert the change for the I see we update to typst 1.10.0 - how do we know Pandoc is up to date to support recent change in Typst ? As a reminder about last time, change in Typst 1.9.0 did break stuff in Pandoc 3.1.9, which required the changes in Pandoc 3.1.10 to support Typst 3.1.9. @cscheid Pandoc 3.1.10 includes Edit: Hidden because not good yet in Pandoc 3.1.10It does also have fix for typst box unless not enough I also see in Release note that Typst now support CSL (jgm/pandoc#9186) - maybe there is some adjustment to do here for I believe we have some adjustment to footnotes too (but I think @dragonstyle already aware) as
Regarding issue to close
|
This is the workaround we shouldn't remove yet. If you read the full issue you'll see that the current Pandoc behavior is still not great. There's no full solution either way, but the workaround we have allows for images to autosize well in some settings (which Pandoc's behavior after the fix doesn't.) |
John's release email noted that they updated to Typst 0.10:
|
How did I missed that ! Great. Hopefully he will continue to add it to release note. 👍 |
Skips moving section footnotes
I'm moving this out of draft (assuming that we've got the various pieces in place post update to typst and pandoc). Pandoc also just did a minor patch w/ bug fixes (3.1.11) which I went ahead and updated to. @dragonstyle Could you review and merge as appropriate once any additional pending work has landed? |
will do! |
The failing tests appear to be related to captions/typst - any chance you could have a quick look @cscheid ? |
@dragonstyle I did not do the reconciliation of templates (some latex and some typst)
@cderv IIRC we put in a workaround of some sort pending a typst update, so let's remove that if appropriate)