Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pandoc 3.1.11 and typst 0.10.0 #7914

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Conversation

jjallaire
Copy link
Collaborator

@dragonstyle I did not do the reconciliation of templates (some latex and some typst)

@cderv IIRC we put in a workaround of some sort pending a typst update, so let's remove that if appropriate)

@cscheid
Copy link
Collaborator

cscheid commented Dec 13, 2023

@cderv IIRC we put in a workaround of some sort pending a typst update, so let's remove that if appropriate)

Just FYI, If you're talking about the image sizing workaround, then my understanding is that the Pandoc fix for that doesn't currently solve the problem, so we need to keep that for a bit longer.

@cderv
Copy link
Collaborator

cderv commented Dec 13, 2023

I did revert the change for the Cite fixup. Pandoc 3.1.10 does indeed solve this issue.

I see we update to typst 1.10.0 - how do we know Pandoc is up to date to support recent change in Typst ?

As a reminder about last time, change in Typst 1.9.0 did break stuff in Pandoc 3.1.9, which required the changes in Pandoc 3.1.10 to support Typst 3.1.9.

@cscheid Pandoc 3.1.10 includes toc-depth support in the writer, the workaround from #7825 may not be needed. There is probably impact on template too (cc @dragonstyle)

Edit: Hidden because not good yet in Pandoc 3.1.10

It does also have fix for typst box

unless not enough
I think we have a workaround for this too:

I also see in Release note that Typst now support CSL (jgm/pandoc#9186) - maybe there is some adjustment to do here for csl support 🤔

I believe we have some adjustment to footnotes too (but I think @dragonstyle already aware) as aside will have doc-footnote now, possibly section be used instead of aside

To conform to validator’s expectations, doc-footnote role is used with aside and doc-endnotes with section.

aside is used only for notes at ends of sections or blocks; if all the notes come at the end of the document, section is used so we can have the doc-endnotes role.

Regarding issue to close

@cscheid
Copy link
Collaborator

cscheid commented Dec 13, 2023

I think we have a workaround for this too:

This is the workaround we shouldn't remove yet. If you read the full issue you'll see that the current Pandoc behavior is still not great. There's no full solution either way, but the workaround we have allows for images to autosize well in some settings (which Pandoc's behavior after the fix doesn't.)

@jjallaire
Copy link
Collaborator Author

John's release email noted that they updated to Typst 0.10:

  • Typst support has been updated to typst v0.10.0 (though support is only
    partial). Typst can now use CSL styles for citations (specify csl
    in the metadata or as a variable when writing typst).

@cderv
Copy link
Collaborator

cderv commented Dec 13, 2023

noted that they updated to Typst 0.10:

How did I missed that ! Great. Hopefully he will continue to add it to release note. 👍

@jjallaire
Copy link
Collaborator Author

I'm moving this out of draft (assuming that we've got the various pieces in place post update to typst and pandoc). Pandoc also just did a minor patch w/ bug fixes (3.1.11) which I went ahead and updated to. @dragonstyle Could you review and merge as appropriate once any additional pending work has landed?

@jjallaire jjallaire marked this pull request as ready for review December 17, 2023 23:27
@jjallaire jjallaire changed the title Update to pandoc 3.1.10 and typst 0.10.0 Update to pandoc 3.1.11 and typst 0.10.0 Dec 17, 2023
@dragonstyle
Copy link
Collaborator

will do!

@dragonstyle
Copy link
Collaborator

The failing tests appear to be related to captions/typst - any chance you could have a quick look @cscheid ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants