Recompute the margin element position whenever body height changes#5303
Merged
dragonstyle merged 1 commit intomainfrom Apr 25, 2023
Merged
Recompute the margin element position whenever body height changes#5303dragonstyle merged 1 commit intomainfrom
dragonstyle merged 1 commit intomainfrom
Conversation
Merely doing it when the dom is complete isn’t enough, since images may not have yet loaded. Instead, just look at the body and observe any resizes, and recompute the changes when that happens (throttled). Fixes #5289
dragonstyle
added a commit
that referenced
this pull request
Apr 25, 2023
Recompute the margin element position whenever body height changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merely doing it when the dom is complete isn’t enough, since images may not have yet loaded. Instead, just look at the body and observe any resizes, and recompute the changes when that happens (throttled).
Fixes #5289