Repository navigation
[backport] Fix Firefox font-size precision failures in revealjs tests (#14854) - #14862
Merged
Merged
Conversation
Firefox resolves the compounding em/rem font-size cascade used by revealjs's smaller-slide/callout scaling with slightly different subpixel rounding than Chromium/WebKit, drifting ~0.006px past the default toBeCloseTo threshold (0.005, from numDigits=2). That default is decimal-digit based, not pixel based, so it's scale-blind and too tight for cross-engine cascade rounding drift. Playwright's own test suite hits the same class of bug (CSS<->DIP rounding drift across engines) and solves it with a fixed absolute pixel tolerance instead of toBeCloseTo(numDigits). Follow that pattern here via a shared expectCloseTo helper. (cherry picked from commit 1277ca4)
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14854 to v1.10.
Test-only change, no user-facing impact:
revealjs-themes.spec.tswas failing deterministically on Firefox in scheduled CI due to subpixel rounding drift (~0.006px) past thetoBeCloseTodecimal-precision threshold. Replaces it with a fixed absolute pixel tolerance, matching Playwright's own approach for cross-engine CSS rounding drift.