fix: propagate fig-alt to Typst image alt text for PDF/UA-1#14110
Open
gordonwoodhull wants to merge 1 commit intomainfrom
Open
fix: propagate fig-alt to Typst image alt text for PDF/UA-1#14110gordonwoodhull wants to merge 1 commit intomainfrom
gordonwoodhull wants to merge 1 commit intomainfrom
Conversation
The fig-alt attribute on computed figures (R/Python code chunks) was not being propagated to Typst's image(alt: "...") parameter, causing PDF/UA-1 validation failures. The propagation logic in figures.lua only handled HTML and LaTeX outputs. Refactored to make fig-alt propagation format-agnostic so it works for Typst and any future formats. Closes #14108 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fig-altnot being propagated to Typst'simage(alt: "...")parameter for computed figures (R/Python code chunks)figures.luato makefig-altpropagation format-agnostic instead of having separate HTML/LaTeX/Typst branchesfig-alton R code chunks producesimage(alt: ...)in Typst outputDetails
The
fig-altpropagation inquarto-pre/figures.luaonly handled HTML and LaTeX outputs. The Typst post-filter inquarto-post/typst.luacorrectly looks forimage.attributes["alt"]and generatesimage(alt: "..."), but the attribute was never set for Typst output.The fix refactors the three format-specific branches into a single block:
alton the float itself (unchanged behavior)float.contentto setalton Image nodesThis means any future format will also automatically get
fig-altpropagation.Closes #14108
Test plan
typst-fig-alt-propagation.qmdpasses (verifiedfig-altfrom R chunk →image(alt: ...)in .typ)typst-image-alt-text.qmdpasses (caption-as-alt, explicit alt)equations-alt.qmdpasses (html, pdf, typst)ua-image-alt-text.qmdpasses (pdf, typst)🤖 Generated with Claude Code